Add event shortcuts (n, m) to Day view command palette #1389
+68
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: victor-enogwe <23452630+victor-enogwe@users.noreply.github.com>
Co-authored-by: victor-enogwe <23452630+victor-enogwe@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update cmd palette to include shortcuts for
Add event shortcuts (n, m) to Day view command palette
Dec 23, 2025
n and m
| id: "create-event", | ||
| children: "Create event [n]", | ||
| icon: "PlusIcon", | ||
| onClick: onEventTargetVisibility(() => openEventFormCreateEvent()), |
Collaborator
There was a problem hiding this comment.
no need to use onEventTargetVisibility here.
Contributor
Author
There was a problem hiding this comment.
Fixed in 3258a57. Removed the wrapper since these functions dispatch events directly to DOM elements.
| id: "edit-event", | ||
| children: "Edit event [m]", | ||
| icon: "PencilSquareIcon", | ||
| onClick: onEventTargetVisibility(() => openEventFormEditEvent()), |
Collaborator
There was a problem hiding this comment.
same as above, no need to use onEventTargetVisibility here.
Contributor
Author
There was a problem hiding this comment.
Fixed in 3258a57. Both event shortcuts now use direct onClick handlers.
Co-authored-by: victor-enogwe <23452630+victor-enogwe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan to Add Missing Shortcuts to Command Palette
Summary
Successfully added the missing "Create event [n]" and "Edit event [m]" shortcuts to the Day view command palette. The shortcuts were already implemented in the keyboard handlers but were not visible in the command palette UI. This ensures users can discover and use these shortcuts through Cmd+K.
Changes
DayCmdPalette.tsxto add two new menu items with direct onClick handlersDayCmdPalette.test.tsxwith tests for the new itemsonEventTargetVisibilitywrapper based on code review feedbackOriginal prompt
n,m#1356💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.