Skip to content

chore: Use pull-through cache for CI container images#4486

Merged
aledegano merged 1 commit into
masterfrom
ci_images_pull_through_cache
Jun 24, 2026
Merged

chore: Use pull-through cache for CI container images#4486
aledegano merged 1 commit into
masterfrom
ci_images_pull_through_cache

Conversation

@aledegano

@aledegano aledegano commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Create and use specific values file for SDSC Renkulab CI-deployments.

/deploy

@aledegano aledegano requested review from a team as code owners June 23, 2026 08:16
@RenkuBot

Copy link
Copy Markdown
Collaborator

You can access the deployment of this PR at https://ci-renku-4486.dev.renku.ch

@aledegano aledegano force-pushed the ci_images_pull_through_cache branch 3 times, most recently from ed4661f to cf558e5 Compare June 23, 2026 10:30
leafty
leafty previously approved these changes Jun 24, 2026
Comment on lines +47 to +51
gitlab:
enabled: false
global:
anonymousSessions:
enabled: true

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to redefine these?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is false and we do not set this flag anywhere else, although it's needed for some of the CI tests.
So as it stand yes we need it, perhaps we could make true the default but I don't know which ramifications that might have outside of our deployments...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and for gitlab.enabled=false? I thought it was already set to false by default.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed that key and internalGitlab as well.

@leafty leafty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMPORTANT NOTICE: this will break CI deployments on all component repositories.

The component repositories will need to use the new values file.

@olevski olevski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a separate minimal values file now?

Comment thread minimal-deployment/minimal-deployment-values.yaml
@leafty

leafty commented Jun 24, 2026

Copy link
Copy Markdown
Member

IMPORTANT NOTICE: this will break CI deployments on all component repositories.

See:

    steps:
      - name: Checkout renku repository
        uses: actions/checkout@v4
        with:
          repository: SwissDataScienceCenter/renku
          sparse-checkout: |
            minimal-deployment

The sparse-checkout argument will need to be updated in all component repositories.

🤔 Wait... This should still work, though the CI/CD should be updated.

@olevski olevski self-requested a review June 24, 2026 12:15
olevski
olevski previously approved these changes Jun 24, 2026
Create and use specific values file for SDSC Renkulab CI-deployments.
@aledegano aledegano dismissed stale reviews from olevski and leafty via 7091407 June 24, 2026 12:30
@aledegano aledegano force-pushed the ci_images_pull_through_cache branch from cf558e5 to 7091407 Compare June 24, 2026 12:30
@aledegano aledegano merged commit ab89e13 into master Jun 24, 2026
19 checks passed
@aledegano aledegano deleted the ci_images_pull_through_cache branch June 24, 2026 12:40
@RenkuBot

Copy link
Copy Markdown
Collaborator

Tearing down the temporary RenkuLab deployment for this PR.

olevski pushed a commit to SwissDataScienceCenter/renku-data-services that referenced this pull request Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants