fix(member-list): prevent overflow and add +n avatar indicator#4023
Merged
andre-code merged 35 commits intofeature/update-search-pagefrom Mar 3, 2026
Merged
Conversation
* Add user page navigation * feat: Add search in user page
Contributor
|
You can access the deployment of this PR at https://renku-ci-ui-4023.dev.renku.ch |
andre-code
force-pushed
the
andrea/move-group-search-to-search-v2
branch
from
2236d63 to
795cada
Compare
andre-code
force-pushed
the
andrea/fix/member-list-visualization-layout
branch
from
132106f to
e4a8198
Compare
andre-code
force-pushed
the
andrea/move-group-search-to-search-v2
branch
from
795cada to
84c7017
Compare
andre-code
force-pushed
the
andrea/fix/member-list-visualization-layout
branch
2 times, most recently
from
38af37b to
4b7ef0e
Compare
Member
lorenzo-cavazzi
left a comment
lorenzo-cavazzi
left a comment
There was a problem hiding this comment.
I like the result 👍
Would it make sense to reuse the avatar class? Unless it's too complicated
…aConnector to own file and rename search filter components
andre-code
force-pushed
the
andrea/move-group-search-to-search-v2
branch
from
079320d to
f75ab31
Compare
andre-code
force-pushed
the
andrea/fix/member-list-visualization-layout
branch
2 times, most recently
from
41fb217 to
bd30507
Compare
andre-code
force-pushed
the
andrea/fix/member-list-visualization-layout
branch
from
bd30507 to
9bd11b6
Compare
lorenzo-cavazzi
requested changes
Feb 20, 2026
Member
lorenzo-cavazzi
left a comment
lorenzo-cavazzi
left a comment
There was a problem hiding this comment.
Looks good! A couple of tiny adjustments before merging
Comment on lines
+29
to
+36
| interface MemberListRowProps { | ||
| members: { | ||
| id: string; | ||
| namespace?: string; | ||
| first_name?: string; | ||
| last_name?: string; | ||
| }[]; | ||
| } |
Member
There was a problem hiding this comment.
It's best if you pick the real types from members.data instead of re-defining a subset
interface MemberListRowProps {
members: ProjectMemberListResponse | GroupMemberResponseList;
}
| for (let i = 0; i < members.length; i++) { | ||
| const el = itemRefs.current[i]; | ||
| if (el) { | ||
| measuredWidths.current[i] = el.scrollWidth; |
Member
There was a problem hiding this comment.
Nitpick: scrollWidth might be larger if we have hidden components. That's not the case, but offsetWidth might be more robust for future changes
Suggested change
| measuredWidths.current[i] = el.scrollWidth; | |
| measuredWidths.current[i] = el.offsetWidth; |
Member
|
P.S: probably not a real-world scenario, but having many members might result in a very long text. I wonder if it makes sense to cut the tooltip text after a number of chars (100? 200?) and add "..." 
|
lorenzo-cavazzi
approved these changes
Feb 20, 2026
Member
lorenzo-cavazzi
left a comment
lorenzo-cavazzi
left a comment
There was a problem hiding this comment.
Lgtm! 🚀
I see the search acceptance test is failing but I guess it will be addressed in the other PR
andre-code
force-pushed
the
andrea/fix/member-list-visualization-layout
branch
from
739280b to
9c756dd
Compare
Replace context-based search with Redux hooks Update filters and results to new state structure Deprecate old utility functions Clean up components and remove unused imports
Move groupSearch to SearchV2 folder and rename components Adapt last search version in global search Replace context-based search with Redux hooks Update filters and results to new state structure Deprecate old utility functions Clean up components and remove unused imports
Base automatically changed from
andrea/move-group-search-to-search-v2
to
feature/update-search-page
February 24, 2026 12:07
…ip text truncation in OverflowBadge
andre-code
force-pushed
the
andrea/fix/member-list-visualization-layout
branch
from
9c756dd to
c2de0c0
Compare
…-visualization-layout
andre-code
force-pushed
the
feature/update-search-page
branch
from
db67039 to
6b5c95f
Compare
Contributor
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
andre-code
added a commit
that referenced
this pull request
Mar 3, 2026
* feat: add search in user page (#3984) * feat: use group search in global search (#3999) Move groupSearch to SearchV2 folder and rename components Adapt last search version in global search Replace context-based search with Redux hooks Update filters and results to new state structure * fix(member-list): prevent overflow and add +n avatar indicator (#4023)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/deploy renku=andrea/update-search-page renku-data-services=main