Closed
Conversation
Contributor
|
You can access the deployment of this PR at https://renku-ci-ui-3968.dev.renku.ch |
ciyer
force-pushed
the
ciyer/3817-logs-refactor
branch
from
eb3d7f7 to
d74dda0
Compare
ciyer
force-pushed
the
ciyer/3817-logs-refactor
branch
from
d74dda0 to
ea6494b
Compare
leafty
reviewed
Jan 12, 2026
Member
leafty
left a comment
leafty
left a comment
There was a problem hiding this comment.
I'm not sure I understand what is the improvement we get from this change. The Logs component still uses async methods in hooks which should be avoided and will still cause issues upon HTTP 500.
Contributor
Author
|
Unclear benefit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/deploy