feat: consistent logging format and json support#1187
Merged
mohammad-alisafaee merged 2 commits intomainfrom Feb 25, 2026
Merged
feat: consistent logging format and json support#1187mohammad-alisafaee merged 2 commits intomainfrom
mohammad-alisafaee merged 2 commits intomainfrom
Conversation
mohammad-alisafaee
force-pushed
the
build/doi-in-data-connector-project-links
branch
3 times, most recently
from
4768a4f to
9425d5c
Compare
Base automatically changed from
build/doi-in-data-connector-project-links
to
build/pagination-for-get-data-connector-project-links
January 29, 2026 13:04
mohammad-alisafaee
force-pushed
the
build/pagination-for-get-data-connector-project-links
branch
4 times, most recently
from
06ef2be to
e0bbc93
Compare
mohammad-alisafaee
force-pushed
the
build/consistent-logging-format
branch
from
115edb3 to
4e4c88a
Compare
mohammad-alisafaee
added
the
do not merge
Contributor
|
You can access the deployment of this PR at https://renku-ci-ds-1187.dev.renku.ch |
mohammad-alisafaee
force-pushed
the
build/consistent-logging-format
branch
6 times, most recently
from
01ebca6 to
7f6b60c
Compare
mohammad-alisafaee
force-pushed
the
build/consistent-logging-format
branch
4 times, most recently
from
47c1dfd to
915bea2
Compare
mohammad-alisafaee
force-pushed
the
build/consistent-logging-format
branch
from
f348aac to
840d358
Compare
mohammad-alisafaee
changed the base branch from
build/pagination-for-get-data-connector-project-links
to
main
mohammad-alisafaee
force-pushed
the
build/consistent-logging-format
branch
3 times, most recently
from
5c4ead6 to
00c7ecc
Compare
| [[tool.mypy.overrides]] | ||
| module = ["test.*"] | ||
| disable_error_code = ["no-untyped-def", "var-annotated", "import-untyped"] | ||
|
|
Contributor
Author
There was a problem hiding this comment.
PyCharm passes files individually to mypy, making it ignore its general settings (e.g. not to scan the test directory). However, it considers these overrides. mypy checks on tests are sometimes useful but they can be noisy if we don't disable some of them. That's why I added this override block and have the checks running for tests while disabling noisy ones.
Pull Request Test Coverage Report for Build 22274316429Details
💛 - Coveralls |
mohammad-alisafaee
force-pushed
the
build/consistent-logging-format
branch
from
00c7ecc to
0609703
Compare
mohammad-alisafaee
requested review from
a team,
SalimKayal and
sgaist
as code owners
mohammad-alisafaee
force-pushed
the
build/consistent-logging-format
branch
2 times, most recently
from
1f67ca8 to
023a9f2
Compare
mohammad-alisafaee
force-pushed
the
build/consistent-logging-format
branch
2 times, most recently
from
ba121d3 to
99c04d0
Compare
olevski
approved these changes
Feb 25, 2026
Member
|
Why the |
mohammad-alisafaee
removed
the
do not merge
Contributor
|
Tearing down the temporary RenkuLab deployment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trace_idin errors to be displayed to users in UI/deploy #notest renku-gateway=build/consistent-logging-format extra-values=enableInternalGitlab=false,dataService.sentry.enabled=true,dataService.sentry.environment=renku-ci-ds-1187,dataService.sentry.dsn=https://5ec3c75875797b564a9f4654d5fc46d5@o4509039310995456.ingest.de.sentry.io/4509044015169616,dataService.sentry.sampleRate=0.0001,gateway.sentry.enabled=true,gateway.sentry.environment=renku-ci-ds-1187,gateway.sentry.dsn=https://b4747210a4b6a37a4ccc33beee2dbea7@o4509039310995456.ingest.de.sentry.io/4509513007693904,gateway.sentry.sampleRate=0.0001