Skip to content

feat: allows searching data connector project links by DOI#1181

Open
mohammad-alisafaee wants to merge 2 commits intomainfrom
build/pagination-for-get-data-connector-project-links
Open

feat: allows searching data connector project links by DOI#1181
mohammad-alisafaee wants to merge 2 commits intomainfrom
build/pagination-for-get-data-connector-project-links

Conversation

@mohammad-alisafaee
Copy link
Copy Markdown
Contributor

@mohammad-alisafaee mohammad-alisafaee commented Jan 19, 2026

  • Adds a /data_connectors/search?doi=... endpoint to get a data connector from a given DOI
  • Adds pagination to the /data_connectors/{data_connector_id}/project_links endpoint
  • Returns project path when querying the endpoint

/deploy

@coveralls
Copy link
Copy Markdown

coveralls commented Jan 19, 2026

Pull Request Test Coverage Report for Build 21485504428

Details

  • 37 of 38 (97.37%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on build/pagination-for-get-data-connector-project-links at 89.059%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/renku_data_services/data_connectors/db.py 14 15 93.33%
Totals Coverage Status
Change from base Build 21478219664: 89.1%
Covered Lines: 23613
Relevant Lines: 26514

💛 - Coveralls

@mohammad-alisafaee mohammad-alisafaee force-pushed the build/pagination-for-get-data-connector-project-links branch from de0c3b8 to 646f21e Compare January 19, 2026 22:39
@mohammad-alisafaee mohammad-alisafaee marked this pull request as ready for review January 19, 2026 23:05
Copy link
Copy Markdown
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: please don't merge this without UI coordination.

Copy link
Copy Markdown
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me.

@mohammad-alisafaee mohammad-alisafaee added the do not merge A PR that has been approved but should not be merged label Jan 22, 2026
@mohammad-alisafaee mohammad-alisafaee force-pushed the build/pagination-for-get-data-connector-project-links branch from 646f21e to 570b238 Compare January 23, 2026 18:40
@mohammad-alisafaee mohammad-alisafaee changed the title feat: add pagination to project_links endpoint feat: allows searching data connector project links by DOI Jan 29, 2026
@RenkuBot
Copy link
Copy Markdown
Contributor

You can access the deployment of this PR at https://renku-ci-ds-1181.dev.renku.ch

@mohammad-alisafaee mohammad-alisafaee force-pushed the build/pagination-for-get-data-connector-project-links branch 2 times, most recently from f02feb1 to be7fe5f Compare January 29, 2026 15:44
@mohammad-alisafaee mohammad-alisafaee force-pushed the build/pagination-for-get-data-connector-project-links branch from be7fe5f to 06ef2be Compare January 29, 2026 15:57
* feat: allow using doi to create/get data connector links to projects

* address review comments

* address review comments
@mohammad-alisafaee mohammad-alisafaee force-pushed the build/pagination-for-get-data-connector-project-links branch from 06ef2be to e0bbc93 Compare January 29, 2026 16:07
@leafty leafty removed the do not merge A PR that has been approved but should not be merged label Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants