Draft
Conversation
* Ensure the mutex is not copied, even when the nodeServer is copied by storing a pointer to the mutex, instead of the mutex itself. * Use Mutex instead of RWMutex, as having two readers of the variable at the same time means we are going to write the state at the same time, corrupting the state file on storage. * Mutex / RWMutex are not recursive / re-entrant in Go, so in two cases we do not call `Unlock()` through `defer` as `persistState()` also takes the lock. * As a rule of thumb, Locking a Mutex should be as close as possible to the resource requiring it, to minimize the size of the critical section / the time spent holding the lock. * Remount each volume in a goroutine, with a rate limits of the number of active routine to prevent contention, and keep under control startup times.
* Refactor * CLI code * servers configurations * ControllerServer * NodeServer * Cleanup warnings in: * controllerserver.go * main.go * Use tags to specify json field names on permanent storage * Make DriverVersion a constant * Protect activeVolume while reading for the metrics * Compute len(ns.mountedVolumes) once
Adapt function prototypes
sambuc
force-pushed
the
sambuc/do-not-merge-test
branch
2 times, most recently
from
7be5233 to
717668c
Compare
sambuc
force-pushed
the
sambuc/do-not-merge-test
branch
3 times, most recently
from
b5cd795 to
c1a291f
Compare
- Use a folder name on the host which contains the deployment, to prevent conflicts in case of multiple deployment on the same host. - Cleaned up a bit the templates to make it easier to compare. - Use a folder under /tmp so that state is cleaned on node reboot, but kept between pod/container restarts --------- Co-authored-by: Tasko Olevski <olevski90@gmail.com>
sambuc
force-pushed
the
sambuc/do-not-merge-test
branch
from
c1a291f to
28f60df
Compare
sambuc
force-pushed
the
sambuc/do-not-merge-test
branch
2 times, most recently
from
b17c8b3 to
c9c5c05
Compare
sambuc
force-pushed
the
sambuc/do-not-merge-test
branch
4 times, most recently
from
ed280d0 to
0dc024a
Compare
…ase, as it is there by default.
sambuc
force-pushed
the
sambuc/do-not-merge-test
branch
from
0dc024a to
302a82e
Compare
sambuc
force-pushed
the
sambuc/do-not-merge-test
branch
from
302a82e to
5aded7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.