fix: Return correct non-interactive session state when pod is gone #1153
Merged
Conversation
sgaist
requested changes
Jun 19, 2026
sgaist
left a comment
sgaist
left a comment
Collaborator
There was a problem hiding this comment.
Some small things otherwise looks good
Contributor
|
You can access the deployment of this PR at https://renku-ci-am-1153.dev.renku.ch |
sgaist
previously approved these changes
Jun 19, 2026
leafty
reviewed
Jun 22, 2026
sgaist
previously approved these changes
Jun 23, 2026
leafty
previously approved these changes
Jun 24, 2026
A pod might be missing for a renku job. Then it must not fall through "not ready".
Also re-use the `failureMessage` method to early determine failure state
This has already been taken care of. The bug only involves successful jobs that have no pods anymore.
failure message should be taken from the fetched job object
eikek
force-pushed
the
fix/job-status-when-pod-missing
branch
from
b1c9bce to
91da796
Compare
eikek
force-pushed
the
fix/job-status-when-pod-missing
branch
from
91da796 to
620e341
Compare
Member
Author
|
I tested it on a data services pr. The deployment was successful when using the |
leafty
approved these changes
Jun 25, 2026
Contributor
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It happens that the pod is gone, but the job and amalthea session still exists. In this case the status of the amalthea session needs to be derived from the job.
/deploy