Open
Conversation
kirahowe
force-pushed
the
rg/visual-hierarchy
branch
from
529f5b2 to
135a976
Compare
Trade speed for memory usage to make marking the indeterminate options faster. Improves performance by ~35% (from ~100ms to ~65ms) for deeply nested options.
kirahowe
force-pushed
the
km/highlight-closed-levels-with-selections
branch
from
9d892c3 to
d52695b
Compare
Contributor
|
I think this looks good. To be honest I can't remember why we haven't already merged it. We've since switched focus onto using global search (#84) for the main UX but I think we may want to retain the original "browsing" UI. I suggest we leave this PR open until we come back to thinking about the browsing approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shows checkboxes for any levels that have any children selected in the "indeterminate" state. One possible solution to close #73.