added Dockerfile and service-json file in flo-executor and flo-server#33
added Dockerfile and service-json file in flo-executor and flo-server#33sugandhpasricha wants to merge 8 commits into
Conversation
sugandhpasricha
commented
Sep 27, 2019
sugandhpasricha
commented
- Dockerfile has been added to containerise conductor based services flo-server and flo-executor.
- flo-server directory is added which contains service-json file for the flo-server service
- flo-executor directory has been added which contains service-json file for flo-executor service
| "memory": 2048, | ||
| "scalingDefinition": [ | ||
| { | ||
| "minReplicas": 1, |
There was a problem hiding this comment.
What does this mean? If cpu is more then 75% still we will use max replicas 1?
There was a problem hiding this comment.
Yes. This can be changed according to the requirement of the service.
This is the default setting of the service-template file.
| "spec": [ | ||
| { | ||
| "type": "container", | ||
| "name": "", |
There was a problem hiding this comment.
Why we are giving empty string in a name?
There was a problem hiding this comment.
All of these are the default setting. It can be changed as per service requirement.
| "healthPort": 8080, | ||
| "healthUrl": "/api/health", | ||
| "metricPort": 8080, | ||
| "accessLevel": "swiggy", |
There was a problem hiding this comment.
Wanted to understand accessLevel swiggy wide.
There was a problem hiding this comment.
Set application endpoint accessibility (internal-vpc/peered vpc, swiggy- From swiggy corporate office)
| { | ||
| "name": "flo-executor", | ||
| "pod": "flo-executor", | ||
| "version": "0.0.3", |
There was a problem hiding this comment.
When do we need to bump up the version? Also why it starts with 0.0.3?
There was a problem hiding this comment.
Any changes in the image or serivce-template.json file will lead to version incrementation.
| @@ -0,0 +1,28 @@ | |||
| { | |||
| "name": "flo-executor", | |||
| "pod": "flo-executor", | |||
There was a problem hiding this comment.
can you elaborate why it should be ff? We are following default setting wherein the pod name and service name is same if not mentioned otherwise.
There was a problem hiding this comment.
ff is the pod name for conductor. Are you sure that we must set pod name as service name. If so can you give me some examples of other services ?
There was a problem hiding this comment.
so far we are using same pod name and service name in "name" and "pod" sections as default setting unless the service is already deployed in rock using a different "pod". If the pod already exists for a particular service coast will not deploy the service in a pod with a different name, it gives an error.
| FROM gradle:4.8.1 AS build | ||
| COPY --chown=gradle:gradle . /home/gradle/conductor | ||
| WORKDIR /home/gradle/conductor | ||
| RUN gradle build -x test |
There was a problem hiding this comment.
gradle build will take time to execute which will increase our docker deployment time. can you please setup so that the jar is directly picked up from swiggy dockerhub.
There was a problem hiding this comment.
The dockerfile structure has already been discussed keeping best practices in consideration.
There was a problem hiding this comment.
@naveenchlsn you can consult this url https://github.com/Netflix/conductor/blob/master/docker/server/Dockerfile , this dockerfile also contains gradle build which comes under best practices
| { | ||
| "type": "container", | ||
| "name": "", | ||
| "image": "hashedin/conductor-server:0.0.1", |
There was a problem hiding this comment.
Consider removing hashedin from here and put ff the pod name
There was a problem hiding this comment.
hashedin is a test repo created in harbor as well as test env created in coast.Image can be push in a different repo as well once it is indicated to be done that way.
| @@ -0,0 +1,28 @@ | |||
| { | |||
| "name": "flo-executor", | |||
| "pod": "flo-executor", | |||
There was a problem hiding this comment.
ff is the pod name for conductor. Are you sure that we must set pod name as service name. If so can you give me some examples of other services ?
3 participants
