[Design] Add SettingView#33
Open
LiSeul wants to merge 2 commits into
Open
Conversation
ikanic
approved these changes
May 25, 2023
Collaborator
ikanic
left a comment
ikanic
left a comment
There was a problem hiding this comment.
고생하셨습니다.
딱히 문제가 될만한 부분은 없고, 작은 제안 사항 하나와 탭뷰 부분에 아이콘에 관한 코멘트 하나 남겨 두었습니다.
참고하시면 좋을 것 같아요.
| SettingView() | ||
| .tabItem { | ||
| Image(systemName: "plus") | ||
| Image(systemName: "gearshape") |
Collaborator
There was a problem hiding this comment.
해당 부분 탭 아이콘에 fill을 사용하고 싶지 않으시다면, environment value 중에서 symbolVariant에 관해서 찾아보시면 좋을 것 같습니다.
Collaborator
Author
There was a problem hiding this comment.
해당부분 좀더 찾아보고 진행하겠습니다 ㅠㅠ
Collaborator
Author
There was a problem hiding this comment.
Teb아이콘이 모두 fill 이여서... 흠..... 회의떄 말씀드리겠슘다! 😀
Comment on lines
+39
to
+53
| .alert(isPresented: $isVersionAlert) { | ||
| Alert(title: Text("버전 정보"), message: Text("현재 버전: 1.0"), dismissButton: .default(Text("확인"))) | ||
| } | ||
|
|
||
| Button(action: { | ||
| self.isResetAlert = true | ||
| }) { | ||
| Text("초기화") | ||
| } | ||
| .font(.subheadline) | ||
| .foregroundColor(.black) | ||
| .alert(isPresented: $isResetAlert) { | ||
| Alert(title: Text("초기화"), message: Text("초기화 하시겠습니까?"), primaryButton: .destructive(Text("초기화"), action: { | ||
| // 초기화 로직 구현 | ||
| }), secondaryButton: .cancel(Text("취소"))) |
Collaborator
There was a problem hiding this comment.
Alert들이 반복된다면 Alert를 띄우는 변수를 하나로 통일하고, Alert들을 하나의 컴포넌트로 뺀 후에, 내부 내용과 동작만 다르게 할 수 있도록 하면 어떨까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation 🥳 (코드를 추가/변경하게 된 이유)
SettingView 추가
Key Changes 🔥 (주요 구현/변경 사항)
ToDo 📆 (남은 작업)
없음
ScreenShot 📷 (참고 사진)
To Reviewers 🙏 (리뷰어에게 전달하고 싶은 말)
드디어 추가했습니다 :)
Reference 🔗
ContentView SettingView아이콘 수정하였는데 gearshape.fill 사용 안했는데 fill 아이콘처럼 떠서 고민입니다.ㅠ
Close Issues 🔒 (닫을 Issue)
Close #24