Improve efficiency of stackly contracts #101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update and format tests - add env variables and improve names - remove whitelist test
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Diogomartf
force-pushed
the
stk-266-improve-efficiency-of-stackly-contracts-and-subgraph
branch
from
96bef94 to
8ba5148
Compare
Diogomartf
force-pushed
the
stk-266-improve-efficiency-of-stackly-contracts-and-subgraph
branch
from
8ba5148 to
756d3d6
Compare
berteotti
reviewed
Dec 17, 2024
ElRodrigote
approved these changes
Dec 17, 2024
… by pre-calculating values and reducing operations - Optimize slotSellAmount(): Cache storage reads and simplify logic
Diogomartf
force-pushed
the
stk-266-improve-efficiency-of-stackly-contracts-and-subgraph
branch
from
756d3d6 to
5b85f24
Compare
Contributor
Author
|
This PR was an exploration of improvements to do to to our contracts to be more efficient and also help improve the subgraph by emmiting events with more data reducing But this update would require us to update all the contracts so it's all uniformed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
initialisedevent to use more data so we can get it on subgraphslotSellAmount(), you're using SafeMath'stryDiv()With Solidity 0.8.x, you can use standard division, which is more gas-efficient.orderSlots(): We can make this function more gas efficient by pre-calculating values and reducing operationsslotSellAmount(): Cache storage reads and simplify logicTest are green ✅
run locally with