fix(STK-267): strategies not working properly with new token picker #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
berteotti
reviewed
Dec 27, 2024
berteotti
reviewed
Dec 27, 2024
| id: 3, | ||
| buyToken: gnosisTokens.WETH, | ||
| daysAmount: 10, | ||
| daysAmount: 4, |
Collaborator
There was a problem hiding this comment.
I know that 10 days of hourly trades is a lot. Any specific reason for choosing 4?
Collaborator
Author
There was a problem hiding this comment.
It fits the current constraint of the maximum hours per hourly trade accepted in our custom timeframe input. Right now, we have a maximum of 96 hours, so 4 days * 24 hours = 96.
We can change any of these variables, but I made this change to fit the constraints explained above.
Deploying stackly-ui with
|
| Latest commit: |
22605e3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9c928597.stackly-ui.pages.dev |
| Branch Preview URL: | https://fix-stk-267-strategies-not-w.stackly-ui.pages.dev |
ElRodrigote
deleted the
fix/stk-267-strategies-not-working-properly-with-new-token-picker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: STK-267
Description
Visual Evidence
https://www.loom.com/share/5210e383aeb54a9891eada4b09d584fb?sid=7d350ff1-231d-41fa-8925-eb964ea87359