Skip to content

Quest Icons as Per KR. #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daneo1989 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Quest Icons as Per KR. #1170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a22f782
Quest Icons as Per KR.
daneo1989 Feb 2, 2026
3867ee5
Update QuestInfoForm.Designer.cs
daneo1989 Feb 2, 2026
f802513
Merge branch 'master' into Door-Quest-Icons
daneo1989 Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Client/MirControls/MirScene.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ private void NewNPCInfo(S.NewNPCInfo info)
GameScene.NPCInfoList.RemoveAll(x => x.Index == info.Info.Index);
GameScene.NPCInfoList.Add(info.Info);
GameScene.OnNPCInfoReceived(info.Info.Index);
if (GameScene.Scene?.MapControl != null && GameScene.Scene.MapControl.Index == info.Info.MapIndex)
GameScene.Scene.MapControl.TextureValid = false;
}

private void NewHeroInfo(S.NewHeroInfo info)
Expand Down Expand Up @@ -246,6 +248,15 @@ private void NewChatItem(S.NewChatItem p)
private void NewQuestInfo(S.NewQuestInfo info)
{
GameScene.QuestInfoList.Add(info.Info);
if (info.Info != null)
{
if (info.Info.NpcInfoIndex > 0)
GameScene.RequestNPCInfo(info.Info.NpcInfoIndex);
if (info.Info.FinishNpcInfoIndex > 0)
GameScene.RequestNPCInfo(info.Info.FinishNpcInfoIndex);
}
if (GameScene.Scene?.MapControl != null)
GameScene.Scene.MapControl.TextureValid = false;
}

private void NewRecipeInfo(S.NewRecipeInfo info)
Expand Down
242 changes: 242 additions & 0 deletions Client/MirScenes/Dialogs/BigMapDialog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -552,6 +552,8 @@ public sealed class BigMapViewPort : MirControl

public MirImageControl[] Players;
public static Dictionary<string, Point> PlayerLocations = new Dictionary<string, Point>();
private readonly List<MirLabel> QuestIcons = new List<MirLabel>();
private readonly List<MirLabel> QuestDoorIcons = new List<MirLabel>();

public BigMapViewPort()
{
Expand Down Expand Up @@ -767,6 +769,11 @@ private void OnBeforeDraw()
button.Location = new Point((int)x - s.Width / 2, (int)y - s.Height / 2);
}

ClearQuestIcons();
UpdateQuestIcons(ParentDialog.CurrentRecord);
ClearQuestDoorIcons();
UpdateQuestDoorIcons(ParentDialog.CurrentRecord);

if (ParentDialog.SelectedNPC != null && SelectedNPCIcon.Visible)
{
float x = ParentDialog.SelectedNPC.Info.Location.X * ScaleX;
Expand All @@ -777,6 +784,241 @@ private void OnBeforeDraw()
SelectedNPCIcon.Location = new Point((int)x - s.Width / 2, (int)y - s.Height / 2);
}
}

private void ClearQuestIcons()
{
for (int i = 0; i < QuestIcons.Count; i++)
QuestIcons[i].Dispose();

QuestIcons.Clear();
}

private void ClearQuestDoorIcons()
{
for (int i = 0; i < QuestDoorIcons.Count; i++)
QuestDoorIcons[i].Dispose();

QuestDoorIcons.Clear();
}

private void UpdateQuestIcons(BigMapRecord currentRecord)
{
if (currentRecord?.MapInfo?.NPCs == null || currentRecord.MapInfo.NPCs.Count == 0) return;
if (MapObject.User == null) return;

Dictionary<uint, ClientQuestProgress> bestQuestByNpc = MapControl.BuildBestQuestByNpc();

if (bestQuestByNpc.Count == 0) return;

for (int i = 0; i < currentRecord.MapInfo.NPCs.Count; i++)
{
ClientNPCInfo npc = currentRecord.MapInfo.NPCs[i];
if (!bestQuestByNpc.TryGetValue(npc.ObjectID, out ClientQuestProgress quest)) continue;
if (!TryGetQuestIconLabel(quest.Icon, out string text, out Color color)) continue;

float x = npc.Location.X * ScaleX;
float y = npc.Location.Y * ScaleY;

QuestIcons.Add(new MirLabel
{
AutoSize = true,
Parent = this,
Font = new Font(Settings.FontName, 9f, FontStyle.Bold),
DrawFormat = TextFormatFlags.HorizontalCenter | TextFormatFlags.VerticalCenter,
Text = text,
ForeColour = color,
Location = new Point((int)x - 6, (int)y - 10),
NotControl = true,
Visible = true,
Modal = true
});
}
}

private void UpdateQuestDoorIcons(BigMapRecord currentRecord)
{
if (currentRecord?.MapInfo?.Movements == null || currentRecord.MapInfo.Movements.Count == 0) return;
if (MapObject.User == null) return;
Dictionary<int, ClientQuestProgress> bestQuestByMap = MapControl.BuildBestQuestByMap(QuestMapIconFlags.DoorBigMap);
if (bestQuestByMap.Count == 0) return;

Dictionary<int, List<ClientMovementInfo>> movementsByDestination = new Dictionary<int, List<ClientMovementInfo>>();
for (int i = 0; i < currentRecord.MapInfo.Movements.Count; i++)
{
ClientMovementInfo movement = currentRecord.MapInfo.Movements[i];
if (!bestQuestByMap.ContainsKey(movement.Destination)) continue;

if (!movementsByDestination.TryGetValue(movement.Destination, out List<ClientMovementInfo> list))
{
list = new List<ClientMovementInfo>();
movementsByDestination[movement.Destination] = list;
}

list.Add(movement);
}

foreach (var entry in movementsByDestination)
{
ClientQuestProgress quest = bestQuestByMap[entry.Key];
if (!TryGetQuestIconLabel(quest.Icon, out string text, out Color color)) continue;

List<List<ClientMovementInfo>> clusters = BuildMovementClusters(entry.Value);
for (int i = 0; i < clusters.Count; i++)
{
PointF center = GetClusterCenter(clusters[i]);
float x = center.X * ScaleX;
float y = center.Y * ScaleY;

QuestDoorIcons.Add(new MirLabel
{
AutoSize = true,
Parent = this,
Font = new Font(Settings.FontName, 9f, FontStyle.Bold),
DrawFormat = TextFormatFlags.HorizontalCenter | TextFormatFlags.VerticalCenter,
Text = text,
ForeColour = color,
Location = new Point((int)x - 6, (int)y - 10),
NotControl = true,
Visible = true,
Modal = true
});
}
}
}


private static bool IsQuestHigherPriority(ClientQuestProgress candidate, ClientQuestProgress current)
{
int candidatePriority = GetQuestTypePriority(candidate.QuestInfo.Type);
int currentPriority = GetQuestTypePriority(current.QuestInfo.Type);

if (candidatePriority != currentPriority)
return candidatePriority < currentPriority;

if (candidate.Completed != current.Completed)
return candidate.Completed;

return candidate.Id < current.Id;
}

private static int GetQuestTypePriority(QuestType type)
{
switch (type)
{
case QuestType.Story:
return 0;
case QuestType.General:
return 1;
case QuestType.Daily:
return 2;
case QuestType.Repeatable:
return 3;
default:
return 4;
}
}

private static bool TryGetQuestIconLabel(QuestIcon icon, out string text, out Color color)
{
text = string.Empty;
color = Color.Empty;

switch (icon)
{
case QuestIcon.ExclamationBlue:
color = Color.DodgerBlue;
text = "!";
break;
case QuestIcon.ExclamationYellow:
color = Color.Yellow;
text = "!";
break;
case QuestIcon.ExclamationGreen:
color = Color.Green;
text = "!";
break;
case QuestIcon.QuestionBlue:
color = Color.DodgerBlue;
text = "?";
break;
case QuestIcon.QuestionWhite:
color = Color.White;
text = "?";
break;
case QuestIcon.QuestionYellow:
color = Color.Yellow;
text = "?";
break;
case QuestIcon.QuestionGreen:
color = Color.Green;
text = "?";
break;
}

return !string.IsNullOrEmpty(text);
}

private static List<List<ClientMovementInfo>> BuildMovementClusters(List<ClientMovementInfo> movements)
{
var clusters = new List<List<ClientMovementInfo>>();
var visited = new bool[movements.Count];

for (int i = 0; i < movements.Count; i++)
{
if (visited[i]) continue;

var cluster = new List<ClientMovementInfo>();
var queue = new Queue<int>();
queue.Enqueue(i);
visited[i] = true;

while (queue.Count > 0)
{
int index = queue.Dequeue();
ClientMovementInfo current = movements[index];
cluster.Add(current);

for (int j = 0; j < movements.Count; j++)
{
if (visited[j]) continue;

ClientMovementInfo candidate = movements[j];
if (!IsAdjacent(current.Location, candidate.Location)) continue;

visited[j] = true;
queue.Enqueue(j);
}
}

clusters.Add(cluster);
}

return clusters;
}

private static bool IsAdjacent(Point a, Point b)
{
return Math.Abs(a.X - b.X) <= 1 && Math.Abs(a.Y - b.Y) <= 1;
}

private static PointF GetClusterCenter(List<ClientMovementInfo> cluster)
{
int minX = int.MaxValue;
int minY = int.MaxValue;
int maxX = int.MinValue;
int maxY = int.MinValue;

for (int i = 0; i < cluster.Count; i++)
{
Point location = cluster[i].Location;
if (location.X < minX) minX = location.X;
if (location.Y < minY) minY = location.Y;
if (location.X > maxX) maxX = location.X;
if (location.Y > maxY) maxY = location.Y;
}

return new PointF((minX + maxX) / 2f, (minY + maxY) / 2f);
}
}

public class BigMapNPCRow : MirButton
Expand Down
Loading