Skip to content

DOCS-1287 - Cachebusting functionality [hold] #6102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
kimsauce wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

DOCS-1287 - Cachebusting functionality [hold] #6102

kimsauce wants to merge 3 commits into from

Conversation

@kimsauce
Copy link
Collaborator

@kimsauce kimsauce commented Dec 9, 2025 •
edited
Loading

Purpose of this pull request

Add function to solve cachebusting on images, JS, and CS. Author: @vfalconisumo. https://gist.github.com/vfalconisumo/aaab7fbd1b57a237472ffd332f7e7276

This is on hold as a backup plan if https://sumologic.atlassian.net/browse/DOCS-1287 fails to solve the Algolia search box disappearing issue.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/DOCS-1287
https://sumologic.atlassian.net/browse/DOCS-1262

@kimsauce kimsauce self-assigned this Dec 9, 2025
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Dec 9, 2025
@kimsauce kimsauce requested a review from vfalconisumo December 9, 2025 20:45
@kimsauce kimsauce marked this pull request as ready for review December 9, 2025 20:45
@kimsauce kimsauce added the doc:site tech Site/tool maintenance, dependencies, updates label Dec 9, 2025
jpipkin1
jpipkin1 approved these changes Dec 9, 2025
View reviewed changes
Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, @kimsauce, although I don't have the skills to properly evaluate it.

Minor point, but should you rename the file from cachbust.js to cachebust.js?

@kimsauce kimsauce added the do-not-merge Pull requests that should not be merged label Dec 10, 2025
@kimsauce kimsauce changed the title Add function to solve cachebusting on images, JS, and CS DOCS-1287 - Cachebusting functionality Dec 10, 2025
@kimsauce kimsauce changed the title DOCS-1287 - Cachebusting functionality DOCS-1287 - Cachebusting functionality [hold] Dec 10, 2025
@kimsauce kimsauce marked this pull request as draft December 12, 2025 04:22
@kimsauce
Copy link
Collaborator Author

kimsauce commented Dec 12, 2025

Looks fine to me, @kimsauce, although I don't have the skills to properly evaluate it.

Minor point, but should you rename the file from cachbust.js to cachebust.js?

OMG, good catch!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpipkin1 jpipkin1 jpipkin1 approved these changes

@vfalconisumo vfalconisumo Awaiting requested review from vfalconisumo

@JV0812 JV0812 Awaiting requested review from JV0812 JV0812 is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

@amee-sumo amee-sumo Awaiting requested review from amee-sumo amee-sumo is a code owner

Assignees

@kimsauce kimsauce

Labels

cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged doc:site tech Site/tool maintenance, dependencies, updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kimsauce @jpipkin1