Skip to content

add timer title#22

Merged
SuddenGunter merged 1 commit intomainfrom
add/page-title
Feb 11, 2026
Merged

add timer title#22
SuddenGunter merged 1 commit intomainfrom
add/page-title

Conversation

@SuddenGunter
Copy link
Owner

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make the browser tab title reflect timer progress/completion for the LiveView timer page.

Changes:

  • Updates the Timer LiveView JS hook to set document.title during countdown and when completed.
  • Replaces the LiveView <.live_title> usage with a static <title>Dash</title> in the root layout.
  • Adds a listeners: [Phoenix.CodeReloader] key to mix.exs project config.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
mix.exs Adds a listeners project config entry referencing Phoenix.CodeReloader.
lib/dash_web/components/layouts/root.html.heex Switches from LiveView-managed <.live_title> to a static <title>.
assets/js/hooks.js Sets document.title to the countdown and “Timer completed!” from the timer hook.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SuddenGunter SuddenGunter merged commit 4eda4d7 into main Feb 11, 2026
7 checks passed
@SuddenGunter SuddenGunter deleted the add/page-title branch February 11, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments