replace 'or' shorthand with explicit 'is None' guards on numeric fields#106
Merged
replace 'or' shorthand with explicit 'is None' guards on numeric fields#106
Conversation
… fields
In get_telescope_status and get_guide_objects, the pattern:
x = x or db_x
silently overwrites a caller-supplied 0.0 with the DB value because
0.0 is falsy. This affects inr, adc, m2_pos3, ra, dec, and inst_pa.
Replace all six occurrences with explicit is None checks:
if x is None:
x = db_x
Closes REFACTORING.md Issue 7 / AGENTS.md G4.
wtgee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In get_telescope_status and get_guide_objects, the pattern:
x = x or db_xsilently overwrites a caller-supplied 0.0 with the DB value because 0.0 is falsy. This affects inr, adc, m2_pos3, ra, dec, and inst_pa. Replace all six occurrences with explicit is None checks: