[한승원] 추상팩토리패턴 & 싱글톤 #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bombo-dev
reviewed
Jun 23, 2023
| private final GUIFactory factory; | ||
| private Button button; | ||
|
|
||
| public Application(GUIFactory factory) { |
Contributor
There was a problem hiding this comment.
생성할 때 같이 createUI를 실행해줘야 할 것 같아요!
혹시나 paint()를 먼저 실행하면 nullPointerException이 ㅠ0ㅠ
| private MacFactory() { | ||
| } | ||
|
|
||
| public static MacFactory getInstance() { |
Contributor
There was a problem hiding this comment.
동시성 문제가 있으니 이전에 발표했었던 inner static class로 변경해보시는건 어떨까요!?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.