-
Notifications
You must be signed in to change notification settings - Fork 9
Simplified Plugin for Better Favicon Support + Caching #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- avatar can get via twenty-icons.com/<domain>. This website actually get domain favicon - add logic to retry subdomain like mail.replit.com: if can not get favicon from subdomain, try getting from root domain.
**summary:** Remove unused dependencies and simplify avatar fetching
|
Thank you for your contribution ! I will test it in mid-January |
|
What do the console logs say. Open up dev tools inspect where you can see them. |
Seems like I need to build it with NPM possibly? Can you upload the already compiled plugin? |
|
Given I'd recommend, deleting the directory
|
|
Tried that, no luck, same error... |
|
To be honest, I think this is an issue with mailspring possibly since the module is not even getting installed. Maybe open an issue on their repo. |
|
But when I go back and install the old version, it installs fine. Trying to figure out what changes may have caused that... |
|
Oh that’s odd. I’m not on Windows and have no way to replicate this. It installs just fine on mac.
…-------- Original Message --------
On Tuesday, 12/30/25 at 10:23 technobulb ***@***.***> wrote:
technobulb left a comment [(Striffly/mailspring-avatars#20)](#20 (comment))
But when I go back and install the old version, it installs fine. Trying to figure out what changes may have caused that...
Thanks for your help!
—
Reply to this email directly, [view it on GitHub](#20 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ABADDDKVOFK3CAK4EMOIXG34EIZA5AVCNFSM6AAAAACP2PDYNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMOJYGYZTGNRSGU).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Same here after installing your branch. |
|
I have no way to debug this. Could one of you two please undertake investigating this issue? My fix works on mac perfectly, so there is that to aim for ;) |
|
Solved. Just needed to be built. |
|
I can confirm it works after compiling. Ran Then it works. Thanks ❤️ |

The plugin provided a good basis, but was not working well recently.
The favicon providers shipped with this plugin either stopped working or changed their API status. There was also a lot of overcomplication in this plugin (like choosing a random color for the circles).
I simplified the plugin and changed the favicon providers to actively maintained ones.
In order, tries to resolve:
https://twenty-icons.com/on the full domainhttps://twenty-icons.com/on the root domainhttps://favicon.vemetric.com/on the full domainhttps://favicon.vemetric.com/on the root domainhttps://cdn.favicon0.com/on the full domainhttps://cdn.favicon0.com/on the root domainAlso to avoid unnecessary favicon GET requests, this plugin caches favicons in an LRU cache (maxSize 4096). If a favicon is requested that is in the cache, the data is used directly rather than hitting the network.
I installed this plugin locally on my mailspring and it works like a charm!