Port WorldTabs, deselect-all, and save-performance fix to 1.21.11#2
Closed
Copilot wants to merge 3 commits into
Closed
Port WorldTabs, deselect-all, and save-performance fix to 1.21.11#2Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/StratCube2/servertabs/sessions/f7fdbb74-65b7-4b39-81c0-b90c973cd4bf Co-authored-by: StratCube2 <176216858+StratCube2@users.noreply.github.com>
…ownWorldIds update order Agent-Logs-Url: https://github.com/StratCube2/servertabs/sessions/f7fdbb74-65b7-4b39-81c0-b90c973cd4bf Co-authored-by: StratCube2 <176216858+StratCube2@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add WorldTabs feature and improve deselect all functionality
Port WorldTabs, deselect-all, and save-performance fix to 1.21.11
Apr 18, 2026
Copilot stopped work on behalf of
StratCube2 due to an error
April 18, 2026 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three features present in the 26.1 branch were missing from the 1.21.11 branch. This PR backports all three.
Performance fix — batch saves in Quick Assign
commitQuickAssignpreviously calledsave()on every server mutation (O(n) disk writes).assignServer/unassignServernow accept adoSaveboolean; the loop passesfalseand a singlesave()fires after all mutations.Deselect All
TabConfig.deselectAllServerTabs(ip)/deselectAllWorldTabs(worldId)— removes all non-locked tab assignments in one saveAssignTabScreenandAssignWorldScreenWorldTabs
Full tab system for
SelectWorldScreen, mirroring the existing server-tab system:WorldTabSessionState— active-tab holder across screen reinitsTabConfig— addedWorldSortingTypeenum, world-tab fields (worldTabs,worldTabAssignments, enabled/dropdown/speed/sort/default/remember/assignOnAdd flags), load/save, and full assignment APIWorldTabsDropdownController— sliding panel onSelectWorldScreen; uses reflection to filter theWorldSelectionList(mirrorsTabDropdownController); supports Alt+W/S tab cyclingAssignWorldScreen— checkbox UI to assign/deassign a world to world tabsWorldTabsSettingsScreen— full settings screen: add/rename/delete/reorder tabs plus all toggle/cycle settingsServerTabsClient— hooksSelectWorldScreen; count-based assign-on-add using a trackedSet<String>of known world IDs; resets world-tab session on title screenTitleScreenMixin— injects a ⚙ WorldTabs gear button next to the Singleplayer row (ServerTabs gear remains next to Multiplayer)Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
maven.fabricmc.net/usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx2G -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant(dns block)/usr/bin/curl curl -s REDACTED(dns block)/usr/bin/curl curl -v REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
This pull request was created from Copilot chat.