feat(pomodoro): implement pomodoro features and add more profile settings#35
Open
Niravanaa wants to merge 1 commit into
Open
feat(pomodoro): implement pomodoro features and add more profile settings#35Niravanaa wants to merge 1 commit into
Niravanaa wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
b15ba4d to
8ec6a38
Compare
8ec6a38 to
e0a5e26
Compare
e0a5e26 to
5e20930
Compare
5e20930 to
2dcfa26
Compare
2dcfa26 to
02c8c5b
Compare
02c8c5b to
32c058d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #15
Closes #16
Closes #17
Closes #18
Type of Change
Summary
This PR expands the Pomodoro break minigame experience with multiple playable game modes, champion visibility, and stricter leaderboard submission rules. It also modularizes game UI into dedicated components for maintainability and improves draw-tracking accuracy for the circle game. Alongside feature delivery, test fixtures and page/action tests were updated to align with the latest schema and timer page data requirements.
Changes
How to Test
pnpm lint,pnpm typecheck, andpnpm build.pnpm test:ci(or focused suites) and verify all tests pass.Screenshots / Recording
Checklist
<type>/<issue-number>-<description>conventionRefs: #NorCloses: #Nfooterpnpm lintpasses with zero warningspnpm typecheckpassespnpm buildsucceedspnpm test:ci)console.log/ debug statements left in production codeNotes for Reviewer
Please pay special attention to the leaderboard semantics change:
allTimeScorenow behaves as best-ever score for ranking.bestScoreis treated as best score for the current day (reset behavior is date-driven viaupdatedAtin action logic).Follow-up suggestion:
dailyBestScore+dailyBestDatefor clearer long-term semantics and reporting.