-
Notifications
You must be signed in to change notification settings - Fork 4
Add folder linkers for libation and nextory #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
StirlingMouse
wants to merge
14
commits into
main
Choose a base branch
from
folder-linkers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
cd79f7b
Start to decouple from MaM
StirlingMouse 9f4a204
Improve cleanup
StirlingMouse dd442cf
Add folder linker
StirlingMouse 7416be1
Check for duplicates while linking folders
StirlingMouse d1c2a26
Add size checking in filters
StirlingMouse 7eb6956
Add initial integration tests
StirlingMouse 477b877
Add more unit tests
StirlingMouse 8f84e0f
Add integration tests for link torrent
StirlingMouse cad99f6
Support editing non-mam torrents
StirlingMouse 1768c48
Fix libation with less data
StirlingMouse 6b49e36
Improve libation series parsing
StirlingMouse c635b68
Add nextory folder support
StirlingMouse 557f81a
Introduce our categories
StirlingMouse ef5ba33
Map libation cats
StirlingMouse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| use crate::ListItemTorrent; | ||
|
|
||
| impl ListItemTorrent { | ||
| pub fn id(&self) -> String { | ||
| self.torrent_id | ||
| .clone() | ||
| .or_else(|| self.mam_id.map(|id| id.to_string())) | ||
| .unwrap_or_default() | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not collapse missing IDs to an empty string.
Returning
""for missingtorrent_id/mam_idmakes distinct items share the same identifier and can cause invalid links or dedupe collisions. Prefer returningOption<String>and handling absence at call sites.Proposed change
impl ListItemTorrent { - pub fn id(&self) -> String { + pub fn id(&self) -> Option<String> { self.torrent_id .clone() - .or_else(|| self.mam_id.map(|id| id.to_string())) - .unwrap_or_default() + .or_else(|| self.mam_id.map(|id| id.to_string())) } }📝 Committable suggestion
🤖 Prompt for AI Agents