Open
Conversation
ahuston-0
commented
May 26, 2022
Collaborator
Author
ahuston-0
left a comment
ahuston-0
left a comment
There was a problem hiding this comment.
Looks good to me! Just gotta see what Prof. Kruger thinks of the changes.
Fix test/CMakeLists.txt structure. The main branch has switched over to using a tree of CMakeLists to clean the structure up a bit. Also readded test2Tabs to the new system. Signed-off-by: ahuston-0 <aliceghuston@gmail.com>
All currently compiling tests have been switched over to the new grailmain. Also, apparently test/xp/CMakeLists.txt was never added to the previous commit. Signed-off-by: ahuston-0 <aliceghuston@gmail.com>
Currently this throws an exception if a tab doesn't exist. My hope is that the branch predictor will notice that the condition is true most of the time and just return most of the time. Signed-off-by: ahuston-0 <aliceghuston@gmail.com>
Copies over .gitattributes from main repo to ensure that files are handled properly. Fixes several tests dependent on GraphWidget and ButtonWidget to ensure that the demos are kept in working condition (and the CI is not spitting out errors every time a push is made) Signed-off-by: ahuston-0 <aliceghuston@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.