Skip to content

Multi draft leagues#90

Open
SteveF92 wants to merge 263 commits into
mainfrom
multi-draft-leagues
Open

Multi draft leagues#90
SteveF92 wants to merge 263 commits into
mainfrom
multi-draft-leagues

Conversation

@SteveF92

@SteveF92 SteveF92 commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Major new feature, will take some time to deploy.

SteveF92 and others added 30 commits May 24, 2026 23:56
…rk, the timestamp on publisher games was being read in wrong, leading to date based logic not working.
# Conflicts:
#	src/FantasyCritic.Lib/BusinessLogicFunctions/ActionProcessor.cs
Co-authored-by: Cursor <cursoragent@cursor.com>
…, snake-draft double-skip UI note.

Co-authored-by: Cursor <cursoragent@cursor.com>
…s, publisher ordering, one-shot conversion, projected-points clarification.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Replace the blanket 'current draft subquery' approach with three distinct primitives (AnyDraftStarted bool, most-recent-year league type, and IsAnyDraftInProgress), since the DraftNumber=1 filter serves semantically different jobs across the read-path stored procedures and repo queries.

Co-authored-by: Cursor <cursoragent@cursor.com>
Replace the DraftNumber=1 filter across read-path stored procedures and inline repo queries with three primitives: AnyDraftStarted (per-league-year EXISTS bool feeding MinimalLeagueYearInfo and public listings), a 3-way most-recent-year league type (MultiDraft/OneShot/Standard) in sp_getleaguesforuser, and an all-drafts COUNT for DraftIsActiveOrPaused. Updates domain/entity/viewmodel shapes, all read/construction sites, and the frontend (3-way league icon, dropped raw Play Status column in favor of a 'no draft started' flag).

Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@SteveF92 SteveF92 closed this Jul 2, 2026
@SteveF92 SteveF92 reopened this Jul 2, 2026
SteveF92 and others added 8 commits July 1, 2026 22:07
Leave at least one open standard slot when pre-filling roster state so StartDraft succeeds under the new readiness rule.

Co-authored-by: Cursor <cursoragent@cursor.com>
Cover GetNewSlotAssignments unit cases and end-to-end CreateLeagueDraft re-slotting for special slots.

Co-authored-by: Cursor <cursoragent@cursor.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 193 out of 193 changed files in this pull request and generated 4 comments.

Comment thread src/FantasyCritic.Lib/Domain/Publisher.cs Outdated
Comment thread src/FantasyCritic.Web/ClientApp/src/components/DraftCreationSettings.vue Outdated
Comment thread src/FantasyCritic.Web/Models/Requests/League/LeagueDraftViewModel.cs Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 193 out of 193 changed files in this pull request and generated 2 comments.

Comment thread src/FantasyCritic.Lib/Services/DraftService.cs
Comment thread src/FantasyCritic.Lib/Services/DraftService.cs
SteveF92 added 2 commits July 3, 2026 00:35
Also fixing GUID bug that actually didn't amount to the much because of the way the MySQL layer is written. But still, it's good to fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants