Open
Conversation
added pooling, reroll and customization functionality to blind slots
3 tasks
Contributor
|
Very cool! I planned a different approach in #1055, replacing the structure of an Ante entirely, but that PR isn't being completed soon I fear. :') (Unless someone wants to add a pannable, map-like UI element) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added pooling, reroll and customization functionality to blind slots.
Blind Slots:
Separate layer from blind, determining a bunch of customizable qualities for each slot. Extends any functionality only associated with the boss blind slot to the big and small blind slot, such as having boss blinds, being able to be rerolled, and ending the ante. Also added utility functions to make use of this new separation between blind slot and blind object, such as when checking for a blind's boss status, or whether it should transition the ante.
Blind pools:
Added simple blind pools. All custom blinds are automatically marked as Boss blinds unless instructed otherwise. All vanilla blinds are marked as boss blinds, except for the small and big blind, which each occupy their own pool. Blinds can have multiple pools, and blinds can be added or removed from pools during a run.
Changes to Skipping:
Skipping can now be disabled and/or hidden. This can be done generally through effects, or defined for each blind slot. Disabling skips makes it so that the UI still appears but is greyed out and cannot be clicked. Hiding it removes the skip tag UI from the blind. The Boss blind slot is exempted, and cannot have a skip tag be enabled.
Changes to Rerolling:
Blind Slots can be individually rerolled. Enabling a slot's reroll functionality will reroll those slots when the existing reroll function is used, like the boss reroll voucher's or the reroll tag's. The new blind slot specific reroll function will always be able to reroll a blind.
Blind Slot Altering & Disabling:
Blind Slots are now set up to allow for their own blind requirement modification, which will be applied separately from the blind object's. Modifications can be a multiplier or a hard value setting, ignoring source value. Slots can also be set up to disallow disabling of the blind object, or disallowing altering the blind requirement. Blind requirement altering can now be done with SMODS.alter_blind_requirement()
Showdown Antes:
The Showdown ante is now configurable. Additional ante numbers can be set to allow for showdown blinds too, and the ability for a blind slot to be able to spawn showdowns can be set separately for each Blind Slot.
Additional Info: