Add support for subscribing to callbacks that return Task#1486
Merged
Conversation
Member
|
I don't like blocking waiting for the task, but since we want thread affinity.. 🤔 Might be worth converting all callbacks to |
Member
Author
Non task callbacks already block, so not sure what difference that makes here.
How would that look? |
Member
Author
|
I don't see how ValueTask can be applied here, so I would stick with Task. |
JustArchi
approved these changes
Mar 22, 2026
Contributor
JustArchi
left a comment
JustArchi
left a comment
There was a problem hiding this comment.
Tests done via https://github.com/JustArchiNET/ArchiSteamFarm/compare/sk2-test
No regressions observed, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@yaakov-h what do you think will this work?
Fixes #1464