Add self-contained single HTML export#116
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
starry-slides export html [deck] --out <file>for command-line single HTML export.url(...), images, audio/video media, posters, and source assets intodata:URLs during HTML export.Single HTMLexport on the samesrc/node/html-export.tsruntime path and document the self-contained export contract.Test Plan
pnpm test src/node/html-export.test.ts packages/slides-core/src/html-export.test.tsNODE_NO_WARNINGS=1 pnpm test src/cli/index.test.ts -t "export html|help variants"pnpm exec biome check src/node/html-export-assets.ts src/node/html-export.ts src/node/html-export.test.ts src/cli/index.ts src/cli/index.test.ts src/cli/commands/export/action.ts src/cli/commands/export/index.ts packages/slides-core/src/html-export.tspnpm buildgit diff --cached --checkNotes
Full
pnpm lintis currently blocked by pre-existing/unrelated formatting findings in tracked package/test-slide files plus the untracked localstarry-slides-demo-day/deck used for manual export smoke testing. This PR's touched files pass targeted Biome checks.Manual smoke check performed by exporting
starry-slides-demo-dayto a single HTML file and opening it viafile://; exported slide images loaded fromdata:URLs with no page errors or failed requests.