Merged
Conversation
notably axcpu, axplat, extern-trait, page_table_multiarch, starry-vm, starry-signal
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates multiple dependencies, primarily focusing on removing unsafe blocks that are no longer needed due to API changes in the updated extern-trait library (0.2 → 0.4). The changes also include updating other dependencies like axcpu, axplat, page_table_multiarch, starry-vm, and starry-signal, along with switching from compile-time CPU configuration to runtime CPU queries.
Changes:
- Removed
unsafeblocks fromfrom_implanddowncast_refcalls followingextern-traitAPI updates - Replaced static
axconfig::plat::CPU_NUMwith runtimeaxhal::cpu_num()calls - Updated dependency versions:
extern-trait(0.2→0.4),linux-raw-sys(0.11→0.12),starry-signal(0.2.4-preview.1→0.3),starry-vm(0.2→0.3),riscv(0.14→0.16),rand(0.9.1→0.10) - Changed
randimport fromRngCoretoRngtrait - Updated arceos subproject commit
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/entry.rs | Removed unsafe block from AxTaskExt::from_impl call |
| core/src/task.rs | Removed unsafe markers from TaskExt impl and downcast_ref call |
| arceos | Updated subproject commit reference |
| api/src/vfs/dev/mod.rs | Changed rand import from RngCore to Rng |
| api/src/syscall/task/schedule.rs | Replaced static CPU_NUM with runtime cpu_num() calls |
| api/src/syscall/task/clone.rs | Removed unsafe block from AxTaskExt::from_impl call |
| api/Cargo.toml | Updated rand (0.9.1→0.10) and riscv (0.14→0.16) versions |
| Cargo.toml | Updated extern-trait, linux-raw-sys, starry-signal, and starry-vm versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notably axcpu, axplat, extern-trait, page_table_multiarch, starry-vm, starry-signal