-
Notifications
You must be signed in to change notification settings - Fork 9
One way trust patch #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…sword to support one-way Kerberos realm trusts.
Add missing word in generic help for remember checkbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
princ is leaked here.
|
Thanks for your time and patience with my C naivete. I won't get a chance to circle around to this for another week or so but I appreciate the feedback. |
|
Hi Russ, The best laid plans of mice and men... I've just gotten a chance to work on fixing this patch. What is the best way to send the changes? As a separate pull request? Thanks! |
|
Well, I'm not the person who would merge, since I'm no longer the upstream maintainer of WebAuth. But what I'd recommend is to just update this pull request with the new version of the patch. That should be the easiest to deal with. |
…sword to support one-way Kerberos realm trusts.
…to oneway-realm Conflicts: lib/krb5.c
|
Hello, Let me know if parts of this are still needing some work. Thanks! |
This patch seems to be working for us so far with some initial testing. I'm not very experienced with C and Kerberos is still new to me, so please let me know if this requires some re-working or if I totally missed a use case. I tried to maintain original behavior as well as add the functionality I described in my e-mail.