Skip to content

Conversation

@kuchytgj
Copy link

This patch seems to be working for us so far with some initial testing. I'm not very experienced with C and Kerberos is still new to me, so please let me know if this requires some re-working or if I totally missed a use case. I tried to maintain original behavior as well as add the functionality I described in my e-mail.

kuchytgj and others added 2 commits March 23, 2015 14:34
…sword to support one-way

Kerberos realm trusts.
Add missing word in generic help for remember checkbox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

princ is leaked here.

@kuchytgj
Copy link
Author

kuchytgj commented May 8, 2015

Thanks for your time and patience with my C naivete. I won't get a chance to circle around to this for another week or so but I appreciate the feedback.

@kuchytgj
Copy link
Author

Hi Russ,

The best laid plans of mice and men...

I've just gotten a chance to work on fixing this patch. What is the best way to send the changes? As a separate pull request? Thanks!

@rra
Copy link
Contributor

rra commented Aug 9, 2015

Well, I'm not the person who would merge, since I'm no longer the upstream maintainer of WebAuth. But what I'd recommend is to just update this pull request with the new version of the patch. That should be the easiest to deal with.

@kuchytgj
Copy link
Author

Hello,
I updated this pull request with changes based on the feedback from Russ. We're now running this in our production environment to meet our multi-realm authentication needs.

Let me know if parts of this are still needing some work. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants