Check for Ubuntu 16.04 and conditionally install Python 3.6 and configure ST2 to use it #194
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,6 +36,7 @@ vars: | |
| distro: | ||
| versions: | ||
| version_str: not installed | ||
| - pipe_into_bootstrap_script: "" | ||
| - bootstrap_script_url: <% coalesce(ctx().bootstrap_script, "https://raw.githubusercontent.com/StackStorm/st2-packages/" + ctx().bootstrap_branch + "/scripts/st2_bootstrap.sh") %> | ||
| - bootstrap_script_arg_dev_or_ver: <% | ||
| switch( | ||
|
|
@@ -99,12 +100,26 @@ tasks: | |
| publish: | ||
| - vm_info: <% result().output.vm_info %> | ||
| - vm_id: <% result().output.vm_info.id %> | ||
| do: check_for_ubuntu_xenial | ||
| - when: <% failed() %> | ||
| publish: | ||
| - vm_id: <% result().output.get("vm_info", {}).get("id") %> | ||
| - failed: True | ||
| do: cleanup | ||
| check_for_ubuntu_xenial: | ||
| action: core.remote | ||
| input: | ||
| hosts: <% ctx().vm_info.private_ip_address %> | ||
| cmd: cat /etc/issue | ||
| next: | ||
| - when: <% succeeded() and "Ubuntu 16" in result().get(ctx().vm_info.private_ip_address).stdout %> | ||
| publish: | ||
| - pipe_into_bootstrap_script: "echo 'y'" | ||
| do: get_bootstrap_script | ||
| - when: <% succeeded() and not "Ubuntu 16" in result().get(ctx().vm_info.private_ip_address).stdout %> | ||
| do: get_bootstrap_script | ||
| - when: <% failed() %> | ||
| do: check_debug_mode | ||
| get_bootstrap_script: | ||
| action: core.remote_sudo | ||
| input: | ||
|
|
@@ -117,7 +132,10 @@ tasks: | |
| action: core.remote_sudo | ||
| input: | ||
| hosts: <% ctx().vm_info.private_ip_address %> | ||
| # If pipe_into_bootstrap_script is not empty, return it + " | " | ||
| # If pipe_into_bootstrap_script is empty, return an empty string | ||
| cmd: >- | ||
| <% switch(ctx().pipe_into_bootstrap_script => concat(ctx().pipe_into_bootstrap_script, " | "), true => "") %> | ||
| bash /tmp/st2_bootstrap.sh | ||
| --<% ctx().pkg_env %> | ||
| --<% ctx().release %> | ||
|
Comment on lines
139
to
141
Member
There was a problem hiding this comment. Feel free to pass that U16 flag to script directly without extra workflow logic as our installer is catch-all and won't fail in case of non-existent CLI param provided.
Member
There was a problem hiding this comment. As StackStorm/st2-packages#682 is now merged, you can add |
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That should work in this particular case.
However I provided
--u16-add-insecure-py3-ppaflag as identified more bash corner cases with the interactive mode under different environments. StackStorm/st2-packages#682. It might be more clear to rely on that new flag.