Merged
Conversation
Bump patch version Update changelog try upgrade try upgrade logging remove coffee Changes based off new hubot version update changelog bump version update version only test nodejs20 rebuild lock after test updates test updates more robot references try including path typo import instead of require make it a module commonjs no more import rename rename all the things Revert "rename all the things" This reverts commit 3e2b4ee. Revert "rename" This reverts commit 0ac4f29. dynamic import try async convert the rest robot class references more class references we go again new more new args changed try again try again try again import change comment out tests for providers no longer supported test updates test updates test updates test updates test updates variable scope cleanup last cleanup
nzlosh
approved these changes
Mar 13, 2025
cognifloyd
approved these changes
Mar 14, 2025
Comment on lines
-25
to
-27
| "coffee-register": "1.0.0", | ||
| "coffee-script": "1.12.7", | ||
| "coffeescript": "1.12.7", |
Member
There was a problem hiding this comment.
At work, we inject a coffeescript that adds rudimentary rbac for chatops. So, removing coffeescript is sad for me as it means extra work to replace that script (maybe compile to js?). But dropping it makes sense here since this repo doesn't make use of it.
Contributor
Author
There was a problem hiding this comment.
Good to know, I just dropped it because it seemed to be a requirement of the old version of hubot-slack, now the new version doesn't require it so I removed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes only support using Slack
Due to multiple deprecations and archival of related chat backend providers, everything has been removed but Slack.
These changes have been tested and running locally in our environments for 3 weeks now without issue.