Skip to content

Comments

chore: remove cruft left over from removing components#2191

Open
dancormier wants to merge 9 commits intobetafrom
dcormier/rm-cruft-from-removed-components
Open

chore: remove cruft left over from removing components#2191
dancormier wants to merge 9 commits intobetafrom
dcormier/rm-cruft-from-removed-components

Conversation

@dancormier
Copy link
Contributor

@dancormier dancormier commented Feb 24, 2026

This PR removes cruft left behind when removing components in #2187.

Notable changes

  • I decided to port styles from the Card and Topbar components it our docs-specific Less as .docs-card and .docs-topbar so we can fully remove those components
  • I gave the topbar a fresh coat of paint to a) more closely match our beta site and b) simplify the styles a little
  • The s-anchor visual regression tests used .s-card previously. I replaced .s-card there with atomic classes that result in a slightly different style than previous, requiring those test images to be regenerated

@dancormier dancormier requested a review from a team February 24, 2026 00:03
@dancormier dancormier added the do-not-merge Pull requests that are in progress and should not be merged yet label Feb 24, 2026
@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2026

🦋 Changeset detected

Latest commit: 0835518

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for stacks ready!

Name Link
🔨 Latest commit 0835518
🔍 Latest deploy log https://app.netlify.com/projects/stacks/deploys/699e379c8fb9300008299911
😎 Deploy Preview https://deploy-preview-2191--stacks.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 24, 2026

Deploy Preview for stacks-svelte ready!

Name Link
🔨 Latest commit 0835518
🔍 Latest deploy log https://app.netlify.com/projects/stacks-svelte/deploys/699e379ccdb64b0008cad8c1
😎 Deploy Preview https://deploy-preview-2191--stacks-svelte.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dancormier dancormier changed the title [WIP] chore: remove cruft left over from removing components chore: remove cruft left over from removing components Feb 24, 2026
@dancormier dancormier marked this pull request as ready for review February 24, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Pull requests that are in progress and should not be merged yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant