🔀 :: (#120) Role Of Student Not Accept SignIn#121
Open
yeongun130 wants to merge 2 commits intodevelopfrom
Open
🔀 :: (#120) Role Of Student Not Accept SignIn#121yeongun130 wants to merge 2 commits intodevelopfrom
yeongun130 wants to merge 2 commits intodevelopfrom
Conversation
Chaejongin12
approved these changes
Jul 15, 2024
Comment on lines
109
to
112
| JoinWaitingButton( | ||
| modifier = modifier.padding(bottom = 96.dp, end = 8.dp), | ||
| onClick = { openDialog = true } | ||
| ) |
Contributor
There was a problem hiding this comment.
이 부분을 플로팅버튼으로 처리하는게 어떨까요?
Contributor
minStone-dev
left a comment
minStone-dev
left a comment
There was a problem hiding this comment.
xml코드를 수정한 이유가 있으실까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 이 PR을 통해 해결하려는 문제가 무엇인가요?
✨ 이 PR에서 핵심적으로 변경된 사항은 무엇인가요?
학생일 경우
https://github.com/user-attachments/assets/fe4d4177-239a-4cb2-a1b7-ca1ee5bf6534
선생님일 경우
https://github.com/user-attachments/assets/9cbd6bcd-99ca-4256-88b7-979cb0de8e4b
🔖 핵심 변경 사항 이외에 추가적으로 변경된 부분이 있나요?
🧐 Review 시 이런 부분을 신경써서 봐주시면 좋겠어요