test: cover new-pair submit states#176
Open
es3298 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apiPostdirectly through the app import pathSaving...submit state while the pair registration request is pending@/module mapper so tests can mock app aliases consistentlyCloses #142
Validation
npm test -- src/app/pairs/new/page.test.tsx --runInBand- 9 tests passednpm run lint- passedgit diff --check- passednpm test -- --runInBand- blocked by existing upstream failures insrc/app/quote/Client.tsx(assetsDifferis referenced but not defined) andsrc/lib/__tests__/theme.test.tsnpm run build- blocked by existing upstreamsrc/app/quote/Client.tsxassetsDiffertype error