docs: document local development workflow#170
Open
jamilahmadzai wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NEXT_PUBLIC_STABLEROUTE_API_BASE, running the dev server, and verifying a PR locally.package.jsonscript, includingtest:watch, and adds the coverage command form withnpm test -- --coverage.http://localhost:3001API base fromsrc/lib/apiClient.tsand which frontend pages expect the backend there.Closes #120
Bounty: GrantFox OSS campaign for issue #120
Validation
npm cicompleted using the lockfile; npm reported existing dependency deprecation/audit warnings.npm run lintpasses.npm test -- src/lib/__tests__/apiClient.test.ts src/lib/__tests__/quote.test.ts --runInBandpasses: 2 suites, 18 tests.package.json, and the env var/default API base/Node floor match repo files.git diff --checkpasses.Baseline notes
npm run buildis currently blocked onmainbysrc/app/quote/Client.tsx:41(Cannot find name 'assetsDiffer'). This PR is documentation-only and does not touch that code path.npm test -- --runInBandis blocked by the same existing quote-page issue:src/app/quote/page.test.tsxfails when the page referencesassetsDiffer.