feat(security): restrict CORS to an origin allowlist#244
Open
changliuchang777 wants to merge 1 commit into
Open
feat(security): restrict CORS to an origin allowlist#244changliuchang777 wants to merge 1 commit into
changliuchang777 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cors()middleware with a CORS origin allowlist driven byCORS_ALLOWED_ORIGINS.Originheader flowing without CORS reflection and leave credentials disabled.CORS_ALLOWED_ORIGINSin the README.Fixes #6
Validation
git diff --check(passes; only Git for Windows LF/CRLF warnings shown)npm test -- --runInBand src/__tests__/cors.test.ts(blocked by existing baseline import-time failure:src/index.tsredeclaresWEBHOOK_MAX_EVENTSbefore this focused suite can run)npm run build(blocked by existing baseline TypeScript errors: duplicate declarations insrc/index.ts, stalePairMetatest fixture shape, missing/undefined quote variables)npm run lint(blocked by existing baseline lint errors in existing files such aserrorHandler.test.ts,securityHeaders.test.ts, and unused declarations insrc/index.ts; this patch adds only one warning in the existing CORS paused POST assertion style)