feat(security): adopt helmet with a strict CSP#242
Draft
vku2018 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
helmet()Content-Security-Policy: default-src 'none'plus explicit Helmet-managedCross-Origin-*headersnosniff,DENY,no-referrer, andmax-age=31536000; includeSubDomainsheader valuessrc/index.tsthat prevented Jest from importing the appCloses #7
Validation
npm test -- src/__tests__/securityHeaders.test.ts --runInBand(32 passing assertions)npx eslint src/__tests__/securityHeaders.test.ts --quietgit diff --checknpm test -- src/__tests__/securityHeaders.test.ts src/__tests__/index.test.ts --runInBand:securityHeaders.test.tspasses, but the broader existingindex.test.tssuite still fails on unrelated runtime behavior such asslippage_bps is not defined, pause-state expectations, and config/bulk quote failuresnpm run build: existing TypeScript errors remain, including missingBULK_ABSOLUTE_MAX, undefinedslippage_bps/min_received,PairMeta.rate, and unrelated test fixture shape issuesnpm run lint: existing repo-wide lint errors remain; the touchedsecurityHeaders.test.tsfile passes the scoped quiet lint check