This repository was archived by the owner on Aug 26, 2021. It is now read-only.
RFTools and XNet Support#214
Draft
Nerdpie wants to merge 6 commits intoSquidDev-CC:minecraft-1.12from
Draft
Conversation
Starting with common behaviors, XNet (smallest mod)
SquidDev
added
enhancement
SquidDev
suggested changes
May 9, 2019
|
|
||
| //REFINE Do we want to provide the max infusion on each `GenericTileEntity`, | ||
| // provide it via a method, or provide `getInfusedFactor` as a percentage? | ||
| out.put("infusionMax", GeneralConfig.maxInfuse); |
Member
There was a problem hiding this comment.
I'd be inclined just to go with meta-provider. I've always had problems with when to expose something as a getter, and when to do it as metadata, but in this case metadata seems fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #158
While hardly ready for a proper PR, I definitely need some input on the design. Starting with a bit of base shared functionality (owner and infusion level, provided by McJtyLib), I set up a test world and grouped items by each (sub)mod. I'm starting with XNet, as it has the fewest blocks/items/entities to support.
I'm not sure if the dependencies being
deobfCompileis necessary; I was having trouble loading my test instance, and some of McJty's code references the obfuscated names (turned out that I needed to bump the version of RFTools Control).