Skip to content

Fix memory leak in compression level with non-Integer #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SpringMT merged 1 commit into from
Dec 23, 2025
Merged

Fix memory leak in compression level with non-Integer #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ext/zstdruby/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,17 @@

extern VALUE rb_cCDict, rb_cDDict;

static int convert_compression_level(VALUE compression_level_value)
static int convert_compression_level(ZSTD_CCtx* ctx, VALUE compression_level_value)
{
if (NIL_P(compression_level_value)) {
return ZSTD_CLEVEL_DEFAULT;
}
if (!RB_INTEGER_TYPE_P(compression_level_value)) {
if (ctx) {
ZSTD_freeCCtx(ctx);
}
rb_raise(rb_eTypeError, "compression level must be an Integer");
}
return NUM2INT(compression_level_value);
}

Expand All @@ -28,7 +34,7 @@ static void set_compress_params(ZSTD_CCtx* const ctx, VALUE kwargs)

int compression_level = ZSTD_CLEVEL_DEFAULT;
if (kwargs_values[0] != Qundef && kwargs_values[0] != Qnil) {
compression_level = convert_compression_level(kwargs_values[0]);
compression_level = convert_compression_level(ctx, kwargs_values[0]);
}
ZSTD_CCtx_setParameter(ctx, ZSTD_c_compressionLevel, compression_level);

Expand Down
2 changes: 1 addition & 1 deletion ext/zstdruby/zstdruby.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ static VALUE rb_cdict_initialize(int argc, VALUE *argv, VALUE self)
VALUE dict;
VALUE compression_level_value;
rb_scan_args(argc, argv, "11", &dict, &compression_level_value);
int compression_level = convert_compression_level(compression_level_value);
int compression_level = convert_compression_level(NULL, compression_level_value);

StringValue(dict);
char* dict_buffer = RSTRING_PTR(dict);
Expand Down