feat: rule severity levels and granular exit codes#2
Merged
Conversation
- Adds `severity: warning | error` field to rules YAML (defaults to error) - Warning rules print results but do not fail the pipeline - Granular exit codes: 0=all pass, 1=error rule failed, 2=warning-only triggered, 3=invalid rules/schema, 4=file not found - ExitCodeError wrapper propagates specific exit codes through anyhow error chain - compute_exit_code() public function for testability - Output table now includes SEVERITY column - 37 tests total (4 in rules.rs, 3 in runner.rs, 7 in main.rs) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
severity: warning | errorfield on rules (defaults toerror). Warning rules display results but do not cause pipeline failure.01error-severity rules failed2warning-severity rules triggered (no errors)34Example
Test plan
errorwhen omitted from YAMLseverity: warningandseverity: errorparse correctlyFailstatus +Warningseverity in resultFailstatus +Errorseverity🤖 Generated with Claude Code