Closed
Conversation
Member
Author
|
Depends on #1641 |
rowleya
requested changes
Feb 9, 2026
| translator_2 = Translator(devices_2) | ||
| model_2 = p.external_devices.ExternalDeviceLifControl( | ||
| devices_2, create_edges, translator_2) | ||
| model_2.set_model_n_synapse_cores(1) |
Member
There was a problem hiding this comment.
Suggested change
| model_2.set_model_n_synapse_cores(1) | |
| p.external_devices.ExternalDeviceLifControl.set_model_n_synapse_cores(1) |
Might be better to advise against calling a class method on an instance?
Member
Author
Comment on lines
+127
to
+145
| self._add_test_cfg_settings() | ||
|
|
||
| def _add_test_cfg_settings(self) -> None: | ||
| """ | ||
| Ideally this function will find nothing to do. | ||
|
|
||
| This is designed for switching scripts like PyNNExamples | ||
| to split mode without the need to change the scripts. | ||
|
|
||
| Better to call set_model_n_synapse_cores in the script | ||
| """ | ||
| n_synapse_cores = get_config_str_list("Simulation", "n_synapse_cores") | ||
| for n_synapse_core in n_synapse_cores: | ||
| path, name, n = n_synapse_core.split(":") | ||
| model_class = getattr(importlib.import_module(path), name) | ||
| model = model_class() | ||
| model.set_model_n_synapse_cores(int(n)) | ||
| logger.warning(f"model:{name} n_synapse_core set to {n} " | ||
| f"based on cfg") |
Member
There was a problem hiding this comment.
Is there a reason this can't just be done in the test script itself?
Comment on lines
+66
to
+71
| n_synapse_cores = None | ||
| @n_synapse_cores = Testing Option! | ||
| A better way is to call set_model_n_synapse_cores on the model. | ||
| Mapping of a AbstractPyNNNeuronModel to n_synapse_cores to be set | ||
| In the format model:n_synapse_cores,model:n_synapse_cores | ||
|
|
Member
Author
|
replaced by #1643 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires: SpiNNakerManchester/TestBase#72
Increases number of binaries tested.
Several test tweaked to test both the original binary and the extra ones
test_binary is the fall back when no tweak-able test found.
tested by https://github.com/SpiNNakerManchester/IntegrationTests/actions/runs/21713093809