Skip to content

Rework github worflow Replace TAG and add a Dev release#1531

Closed
Jhobean wants to merge 0 commit intoSphereserver:devfrom
Jhobean:Workflow_Rework
Closed

Rework github worflow Replace TAG and add a Dev release#1531
Jhobean wants to merge 0 commit intoSphereserver:devfrom
Jhobean:Workflow_Rework

Conversation

@Jhobean
Copy link
Copy Markdown
Contributor

@Jhobean Jhobean commented Dec 5, 2025

I reworked the Workflows. This bring 2 features
1- delete the Tag each time and update all the date and sources files
2- Add a release for dev branch.

Tested and work Ok on my fork

@mtwango
Copy link
Copy Markdown
Member

mtwango commented Mar 2, 2026

Few notes:

  • Can you check the permissions on the actions? Some I think are very loose (write) and some actions are missing actions.
  • The tag should have different name (like development). Otherwise you will have ambiguous name dev for tag and branch
  • The condition for coverity scan should be better done checking if the secret is set (not empty), so forked repos can run their own covscan, if they have their keys
  • Why are you resseting the tag? To show the latest time on tags page? Wouldn't it be better to use move_existing_tag: true in gh release action?

Also, please keep the changes clean. As I understand it, it was generated with AI, but its hard to see what changed (new stuff, changed stuff) and what was just refactored (some blocks moved, whitespaces added and removed). Thank you

@Jhobean
Copy link
Copy Markdown
Contributor Author

Jhobean commented Mar 3, 2026

The purpose about the tag and write mode was necessery because i was delete the old tag and recreate one. The purpose is to have the correct date write next to the version.

I recheck after the spring break.

@Jhobean Jhobean marked this pull request as draft March 11, 2026 19:50
@Jhobean Jhobean closed this Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants