Skip to content

YT-CPPHGL-15: Validate bf-directed hypergraph binding operations for the incidence list model #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SpectraL519 merged 2 commits into from
Dec 30, 2025
Merged

YT-CPPHGL-15: Validate bf-directed hypergraph binding operations for the incidence list model #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4de8355
comment :)
SpectraL519 Dec 30, 2025
1633d11
working implementation
SpectraL519 Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/hgl/impl/incidence_list.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,16 +289,16 @@ class incidence_list<hgl::bf_directed_t, LayoutTag> final {
gl_attr_force_inline void bind_tail(
const types::id_type vertex_id, const types::id_type hyperedge_id
) noexcept {
// TODO: validate if minor_id is not in head
const auto [major_id, minor_id] = layout_tag::majmin(vertex_id, hyperedge_id);
this->_remove_no_align(this->_major_storage[major_id].head, minor_id);
this->_unique_insert(this->_major_storage[major_id].tail, minor_id);
}

gl_attr_force_inline void bind_head(
const types::id_type vertex_id, const types::id_type hyperedge_id
) noexcept {
// TODO: validate if minor_id is not in tail
const auto [major_id, minor_id] = layout_tag::majmin(vertex_id, hyperedge_id);
this->_remove_no_align(this->_major_storage[major_id].tail, minor_id);
this->_unique_insert(this->_major_storage[major_id].head, minor_id);
}

Expand Down
60 changes: 60 additions & 0 deletions tests/source/hgl/test_incidence_list.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,6 +783,36 @@ TEST_CASE_FIXTURE(
CHECK(std::ranges::contains(vertices, constants::id1));
}

TEST_CASE_FIXTURE(
test_bf_directed_vertex_major_incidence_list,
"binding methods should rebind the elements if they are already bound"
) {
sut_type sut{constants::n_vertices, constants::n_hyperedges};
constexpr auto vertex_id = constants::id1, hyperedge_id = constants::id2;

REQUIRE_FALSE(sut.are_bound(vertex_id, hyperedge_id));
REQUIRE_FALSE(sut.is_head(vertex_id, hyperedge_id));
REQUIRE_FALSE(sut.is_head(vertex_id, hyperedge_id));

// initial bind
sut.bind_head(vertex_id, hyperedge_id);
CHECK(sut.are_bound(vertex_id, hyperedge_id));
CHECK(sut.is_head(vertex_id, hyperedge_id));
CHECK_FALSE(sut.is_tail(vertex_id, hyperedge_id));

// rebind tail
sut.bind_tail(vertex_id, hyperedge_id);
CHECK(sut.are_bound(vertex_id, hyperedge_id));
CHECK(sut.is_tail(vertex_id, hyperedge_id));
CHECK_FALSE(sut.is_head(vertex_id, hyperedge_id));

// rebind head
sut.bind_head(vertex_id, hyperedge_id);
CHECK(sut.are_bound(vertex_id, hyperedge_id));
CHECK(sut.is_head(vertex_id, hyperedge_id));
CHECK_FALSE(sut.is_tail(vertex_id, hyperedge_id));
}

TEST_CASE_FIXTURE(
test_bf_directed_vertex_major_incidence_list,
"unbind should erase the hyperedge id from a proper vertex entry"
Expand Down Expand Up @@ -1104,6 +1134,36 @@ TEST_CASE_FIXTURE(
CHECK(std::ranges::contains(hyperedges, constants::id1));
}

TEST_CASE_FIXTURE(
test_bf_directed_vertex_major_incidence_list,
"binding methods should rebind the elements if they are already bound"
) {
sut_type sut{constants::n_vertices, constants::n_hyperedges};
constexpr auto vertex_id = constants::id1, hyperedge_id = constants::id2;

REQUIRE_FALSE(sut.are_bound(vertex_id, hyperedge_id));
REQUIRE_FALSE(sut.is_head(vertex_id, hyperedge_id));
REQUIRE_FALSE(sut.is_head(vertex_id, hyperedge_id));

// initial bind
sut.bind_head(vertex_id, hyperedge_id);
CHECK(sut.are_bound(vertex_id, hyperedge_id));
CHECK(sut.is_head(vertex_id, hyperedge_id));
CHECK_FALSE(sut.is_tail(vertex_id, hyperedge_id));

// rebind tail
sut.bind_tail(vertex_id, hyperedge_id);
CHECK(sut.are_bound(vertex_id, hyperedge_id));
CHECK(sut.is_tail(vertex_id, hyperedge_id));
CHECK_FALSE(sut.is_head(vertex_id, hyperedge_id));

// rebind head
sut.bind_head(vertex_id, hyperedge_id);
CHECK(sut.are_bound(vertex_id, hyperedge_id));
CHECK(sut.is_head(vertex_id, hyperedge_id));
CHECK_FALSE(sut.is_tail(vertex_id, hyperedge_id));
}

TEST_CASE_FIXTURE(
test_bf_directed_vertex_major_incidence_list, "unbind should clear the corresponding bit"
) {
Expand Down