Skip to content

Fix: Set model fields as optional if they're not explicitly used for node/edge generation logic#8

Merged
d3vzer0 merged 15 commits into
mainfrom
fix/optionals
Jun 8, 2026
Merged

Fix: Set model fields as optional if they're not explicitly used for node/edge generation logic#8
d3vzer0 merged 15 commits into
mainfrom
fix/optionals

Conversation

@d3vzer0

@d3vzer0 d3vzer0 commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixed a collection issue where specific Okta fields were expected/required by the Pydantic model. This change sets these fields to be optional if they're not used (yet) for node/edge creation.

Motivation and Context

This fixes the issues as described above.

Resolves: BED-8389

How Has This Been Tested?

  • Ran collection, preprocessing an conversion for the Okta collector on both OktaPreview tenants. Compared the count of unique nodes/edges based on a collection dataset before this change and after this change. Additionally, verified if this matches with Okta's OpenAPI schema.

Screenshots (if appropriate):

okta1 okta2

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@d3vzer0 d3vzer0 marked this pull request as ready for review May 28, 2026 18:32
@d3vzer0 d3vzer0 merged commit f8d13f4 into main Jun 8, 2026
2 checks passed
@d3vzer0 d3vzer0 deleted the fix/optionals branch June 8, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants