Open
Conversation
Author
|
While this don't get merged, here's a patch I've made in case of anyone need: |
Author
|
@Sparticuz Can you please take a look to merge this? |
Owner
|
Thanks for the PR! Sorry it was a little bit before I could look at it. My main question is this. Can't you just add that directory to EDIT: what I mean by that is something like this process.env["PATH"] = `${process.env["PATH"]}:${path.join(process.cwd(),"qpdf_dir","bin")}` |
Sparticuz
requested changes
Dec 6, 2023
Owner
Sparticuz
left a comment
There was a problem hiding this comment.
I've added a few notes. Thanks!
Author
I'll see if can manage it to work using your suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this we can pass a custom
qpdfbinary path.If user wants to use source compiled or standalone versions of
qpdfbinaries.In my case I needed to use the standalone Linux binary release because
qpdfcannot be installed nor used as a layer.Here's an example of usage: