UIComponent: Improve vertical scrolling & add support for horizontal scrolling#176
Merged
Merged
Conversation
…scrolling Linear: EM-3575
Johni0702
requested changes
Mar 17, 2026
… in ScrollComponent Linear: EM-3575
RedEpicness
force-pushed
the
feature/scrolling-improvements
branch
from
38d19f9 to
dc23648
Compare
Contributor
Author
|
I have not done extensive testing of the scroll component in-game yet to verify old vs new behavior as using my local maven artifact fails to compile for some reason so i'm pushing the changes to get a CI build to test against. The code should still be ready for review though, just wanted to mention that I might still add a change if i find a bug in testing. If you wish you can also wait until I test everything before reviewing though. |
Linear: EM-3575
Johni0702
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the new mouse scroll callback introduced in UniversalCraft#128 under a new Elementa version. Now that scroll deltas are consistent across versions, we stop coercing them to the -1.0 to 1.0 range to allow much more natural scrolling. Alongside this we also add horizontal scrolling
support.
Linear: EM-3575