Skip to content

feat(ui): reverse sheet primary button colors, fix liquid QR icon#183

Merged
Kelbie merged 1 commit intomainfrom
feat/ui-sheet-buttons-qr-icon
Mar 7, 2026
Merged

feat(ui): reverse sheet primary button colors, fix liquid QR icon#183
Kelbie merged 1 commit intomainfrom
feat/ui-sheet-buttons-qr-icon

Conversation

@Kelbie
Copy link
Contributor

@Kelbie Kelbie commented Mar 7, 2026

What / Why

  • Sheet primary buttons (e.g. "Generate new account") now use reversed colors: foreground as background, background as text — higher contrast and clearer CTA
  • Liquid glass QR button icon now uses foreground/white instead of dimmed shade-300 — better visibility on glass

What changed

  • PopupHost: added getSheetButtonClassName/getSheetButtonLabelClassName, applied to all sheet primary buttons (standard, custom footer, profile switcher)
  • QRButton.ios: pass color (foreground) to liquid variant instead of shadeColor300
  • Prettier: fix tabs layout trailing newline

Test plan

  1. Open any sheet with primary button (profile switcher, camera permission, etc.) — primary should show light text on dark bg
  2. On liquid-glass device, QR button icon should be white/foreground
  3. npm run lint && npm run type-check && npm run pretty:check && npm run knip && npm test — all pass

Notes / Risks

  • None

Made with Cursor

- Sheet primary buttons: bg-foreground, text-background (reversed from default)
- Liquid glass QR button: use foreground color for icon (was shade-300)
- Prettier: fix tabs layout trailing newline

Made-with: Cursor
@Kelbie Kelbie merged commit 1c38147 into main Mar 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant