Skip to content

Bugfix: volume-types-check not mandatory #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garloff merged 2 commits into from
Jul 2, 2025
Merged

Bugfix: volume-types-check not mandatory #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
167ac10
Bugfix: volume-types-check not mandatory
mbuechse Apr 29, 2025
3991aee
Merge branch 'main' into issue/907
garloff Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/iaas/volume-types/volume-types-check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def main(argv):
f"{c[logging.CRITICAL]} / {c[logging.ERROR]} / {c[logging.WARNING]}"
)
if not c[logging.CRITICAL]:
print("volume-types-check: " + ('PASS', 'FAIL')[min(1, c[logging.ERROR])])
print("volume-types-check: " + ('PASS', 'FAIL')[min(1, c[logging.ERROR] + c[logging.WARNING])])
return min(127, c[logging.CRITICAL] + c[logging.ERROR]) # cap at 127 due to OS restrictions


Expand Down
2 changes: 1 addition & 1 deletion Tests/scs-compatible-iaas.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ modules:
args: -c {os_cloud} -d
testcases:
- id: volume-types-check
tags: [mandatory]
tags: [volume-types-check]
description: >
Must fulfill all requirements of <https://docs.scs.community/standards/scs-0114-v1-volume-type-standard>
- id: scs-0115-v1
Expand Down