Skip to content

Conversation

@mbuechse
Copy link
Contributor

Resolves #1007.

The login prompt generated by the serial getty service could mess up the output and throw off our primitive parser.

Thanks @garloff for the crucial tip!

Resolves #1007.

The login prompt generated by the serial getty service could mess up the output and throw off our primitive parser.

Thanks @garloff for the crucial tip!

Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
@mbuechse mbuechse requested review from berendt and garloff October 30, 2025 19:22
@mbuechse
Copy link
Contributor Author

I have tested this code. I added debug output for the whole console output, and the login prompt no longer appears in multiple attempts. I am pretty confident that the problem is gone or at least greatly reduced...

Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot judge for sure whether this provides a 100% guarantee to solve the issue or there is a possible race left where systemd has already invoked the getty process that is in the scheduling queue and that outputs the login prompt still intermingled with the debug output. Maybe it's impossible, maybe it's not. In the latter case, it's for sure very unlikely, and as our lives do not depend on it, I'd judge this good enough. Time will tell if we still have <0.1% fails left or not. If so, we can deal with it then. For sure, this is a huge improvement.

@mbuechse mbuechse merged commit d362fc9 into main Oct 30, 2025
9 checks passed
@mbuechse mbuechse deleted the issue/1007 branch October 30, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Heisenbug parsing console output in entropy check

4 participants