Potential fix for code scanning alert no. 1: Workflow does not contain permissions #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Kurt Garloff <kurt@garloff.de>
Signed-off-by: Kurt Garloff <kurt@garloff.de>
garloff
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/SovereignCloudStack/cluster-stacks/security/code-scanning/1
To address the problem, explicitly restrict the permissions granted to the GITHUB_TOKEN in the workflow by adding a
permissions:key. The best practice is to set this at the broadest scope with the least necessary privileges, which in this workflow is at the top level (directly aftername:and before"on":). For this workflow, "contents: read" is sufficient as it only needs to clone the repository and perform linting without making any changes or needing write access. No additional imports, methods, or variable definitions are necessary—just the addition of thepermissions:block.Suggested fixes powered by Copilot Autofix. Review carefully before merging.